Own wifi #65

2026-09-13T14:14:28+02:00

rhetenor commented

2026-09-13 14:14:28 +02:00

this removes the ineffable wifimanager crate which brings much too many unneeded dependencies and does not work with a separate flash implementation.

for now wifi credentials can be provided in two ways:
first via environment variables WIFI_SSID and WIFI_PASS and second via a signal WIFI_CREDENTIALS which can be evoked by anyone in the software.
plan is to integrate this into our NFC task such that the credentials can be read via wifi.

this removes the ineffable wifimanager crate which brings much too many unneeded dependencies and does not work with a separate flash implementation. for now wifi credentials can be provided in two ways: first via environment variables `WIFI_SSID` and `WIFI_PASS` and second via a signal WIFI_CREDENTIALS which can be evoked by anyone in the software. plan is to integrate this into our NFC task such that the credentials can be read via wifi.

rhetenor requested review from ede1998 2026-09-13 14:14:36 +02:00

ede1998 approved these changes 2026-09-13 14:39:42 +02:00

src/lib.rs Outdated

						
				@@ -78,3 +82,3 @@

				///

				#[unsafe(no_mangle)]

				pub extern "Rust" fn _embassy_trace_executor_idle(executor_id: u32) {}

				pub extern "Rust" fn _embassy_trace_executor_idle(_executor_id: u32) {}

ede1998 commented

2026-09-13 14:36:04 +02:00

Nit: remove test code? Or move to separate module only compiled with some embassy_debug feature?

Nit: remove test code? Or move to separate module only compiled with some `embassy_debug` feature?

src/network/wifi.rs Outdated

						
				@@ -51,3 +81,2 @@

				    // Preload connection data so init_wm can connect immediately without AP setup.

				    let nvs = esp_hal_wifimanager::Nvs::new_from_nvs(nvs, 0, 0);

				    // get wifi credentials from env WIFI_SSID; WIFI_PASS (priority) or storage

ede1998 commented

2026-09-13 14:37:23 +02:00

Nit: triple / (///) for doc comments

Nit: triple `/` (`///`) for doc comments

src/network/wifi.rs Outdated

						
				@@ -57,3 +91,1 @@

				    // Wokwi simulation uses a default open network called "Wokwi-GUEST"

				    wm_settings.ssid.clear();

				    _ = core::fmt::write(&mut wm_settings.ssid, format_args!("Wokwi-GUEST"));

				        if env_ssid.is_none() && option_stored_credentials.is_none() {

ede1998 commented

2026-09-13 14:38:15 +02:00

This prevents passwordless wifi networks from working ;D

rhetenor added 3 commits 2026-09-15 20:54:54 +02:00

use own wifi implementation to connect to wifi. store credentials in flash. no wifi connection yet 47b539f364

wifi: implement station change and connect ffc5899c33

wifi: fix issue with initialization 4f251de3d5

tertiary display: implement feature flag to disable
common: remove debug from cargo config, use ESP_LOG="creaturedex:debug"

rhetenor force-pushed own-wifi from 3c56f6b7e1 to 4f251de3d5

2026-09-15 20:54:54 +02:00

Compare

rhetenor merged commit 4f251de3d5 into main

2026-09-15 20:55:39 +02:00

rhetenor deleted branch own-wifi

2026-09-15 20:55:39 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: rhetenor/creaturedex#65