rhetenor/flippr-code
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

consting things

Browse Source
This commit is contained in:
Jonas Zeunert
2018-12-14 03:43:13 +01:00
parent 2b9981e521
commit 57ec8fda79
21 changed files with 58 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
FlippR-Driver/src/input/EventNotifier.h
View File

@@ -25,7 +25,7 @@ public:
virtual void register_event_handler(EventHandler* handler) = 0;
virtual void unregister_event_handler(EventHandler* handler) = 0;
virtual void distribute_event(Event &event) = 0;
virtual void distribute_event(const Event &event) = 0;
};
}

2
FlippR-Driver/src/input/InputPinController.h
View File

@@ -20,7 +20,7 @@ class InputPinController
public:
virtual ~InputPinController() = default;
virtual bool read_data(uint8_t pin) const = 0;
virtual bool read_data(const uint8_t &pin) const = 0;
};
}

4
FlippR-Driver/src/input/impl/Detector.cpp
View File

@@ -34,7 +34,7 @@ Detector::~Detector()
this->detect_thread.join();
}
void Detector::detect()
void Detector::detect() const
{
while(this->is_running)
{
@@ -42,7 +42,7 @@ void Detector::detect()
}
}
void Detector::check_inputs()
void Detector::check_inputs() const
{
for(auto &event : events)
{

4
FlippR-Driver/src/input/impl/Detector.h
View File

@@ -40,8 +40,8 @@ public:
~Detector() override;
private:
void detect();
void check_inputs();
void detect() const;
void check_inputs() const;
private:
const std::unique_ptr<input::InputPinController> input_gpio_interface;

2
FlippR-Driver/src/input/impl/EventNotifier.cpp
View File

@@ -51,7 +51,7 @@ void EventNotifier::unregister_event_handler(EventHandler *handler)
this->event_handlers.erase(handler);
}
void EventNotifier::distribute_event(Event &event)
void EventNotifier::distribute_event(const Event &event)
{
this->event_queue->push(event);
}

2
FlippR-Driver/src/input/impl/EventNotifier.h
View File

@@ -38,7 +38,7 @@ public:
void register_event_handler(EventHandler *handler) override;
void unregister_event_handler(EventHandler *handler) override;
void distribute_event(Event &event) override;
void distribute_event(const Event &event) override;
private:
void notify();

6
FlippR-Driver/src/input/impl/InputPinController.cpp
View File

@@ -28,7 +28,7 @@ InputPinController::InputPinController(std::map<std::string, uint8_t> pins)
init_pins();
}
bool InputPinController::read_data(uint8_t pin) const
bool InputPinController::read_data(const uint8_t &pin) const
{
// setting address to read
write_row(pin / INPUT_MATRIX_SIZE);
@@ -40,14 +40,14 @@ bool InputPinController::read_data(uint8_t pin) const
return read_pin(this->pins.at("data_address"));
}
void InputPinController::write_row(u_int8_t data) const
void InputPinController::write_row(const u_int8_t &data) const
{
write_pin(this->pins.at("row_address_A"), data & 0b001u);
write_pin(this->pins.at("row_address_B"), data & 0b010u);
write_pin(this->pins.at("row_address_C"), data & 0b100u);
}
void InputPinController::write_col(uint8_t data) const
void InputPinController::write_col(const uint8_t &data) const
{
write_pin(this->pins.at("col_address_A"), data & 0b001u);
write_pin(this->pins.at("col_address_B"), data & 0b010u);

6
FlippR-Driver/src/input/impl/InputPinController.h
View File

@@ -26,12 +26,12 @@ class InputPinController : public input::InputPinController, public PinControlle
{
public:
explicit InputPinController(std::map<std::string, uint8_t> pins);
bool read_data(uint8_t pin) const override;
bool read_data(const uint8_t &pin) const override;
private:
void init_pins() const;
void write_row(u_int8_t data) const;
void write_col(uint8_t data) const;
void write_row(const u_int8_t &data) const;
void write_col(const uint8_t &data) const;
private:
const std::map<std::string, uint8_t> pins;