renamed impl to detail

FlippR-Driver/src/output/items/DriverBoardItem.h

@@ -5,7 +5,7 @@
 #ifndef FLIPPR_DRIVER_IDRIVERBOARDITEM_H
 #define FLIPPR_DRIVER_IDRIVERBOARDITEM_H
 
-#include "output/items/impl/Item.h"
+#include "output/items/detail/Item.h"
 
 #include <output/DriverBoardPinController.h>
 
@@ -18,11 +18,11 @@ namespace output
 namespace items
 {
 
-class DriverBoardItem : public impl::Item
+class DriverBoardItem : public detail::Item
 {
 public:
   DriverBoardItem(std::shared_ptr<DriverBoardPinController> pin_controller, uint8_t address, std::string name) :
-  pin_controller(std::move(pin_controller)), impl::Item(address, std::move(name)) {}
+  pin_controller(std::move(pin_controller)), detail::Item(address, std::move(name)) {}
 
   ~DriverBoardItem() override = default;
 

FlippR-Driver/src/output/items/detail/Display.h

@@ -18,7 +18,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 template<int DigitCount>
@@ -28,8 +28,8 @@ public:
   Display(uint8_t address, uint8_t id);
   virtual ~Display() = default;
 
-  virtual void write_score(uint score);
-  virtual void write_content(std::array<char, DigitCount> content);
+  void write_score(uint score) override;
+  void write_content(std::array<char, DigitCount> content);
 
   std::vector<uint8_t> get_content() const override;
   uint8_t get_address() const override;

FlippR-Driver/src/output/items/detail/Display.hpp

@@ -13,7 +13,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 template<int DigitCount>

FlippR-Driver/src/output/items/detail/EightDigitDisplay.h

@@ -5,7 +5,7 @@
 #ifndef FLIPPR_DRIVER_OUTPUT_ITEMS_IMPL_EIGHTDIGITDISPLAY_H
 #define FLIPPR_DRIVER_OUTPUT_ITEMS_IMPL_EIGHTDIGITDISPLAY_H
 
-#include "output/items/impl/Display.h"
+#include "output/items/detail/Display.h"
 
 #include "output/items/EightDigitDisplay.h"
 
@@ -15,7 +15,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 class EightDigitDisplay : public Display<8>, public items::EightDigitDisplay

FlippR-Driver/src/output/items/detail/Item.cpp

@@ -10,7 +10,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 Item::Item(uint8_t address, std::string name) :

FlippR-Driver/src/output/items/detail/Item.h

@@ -19,7 +19,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 class Item : public items::Item

FlippR-Driver/src/output/items/detail/Lamp.cpp

@@ -13,7 +13,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 Lamp::Lamp(std::shared_ptr<DriverBoardPinController> pin_controller, uint8_t address, std::string name) :

FlippR-Driver/src/output/items/detail/Lamp.h

@@ -17,7 +17,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 class Lamp : public DriverBoardItem, public items::Lamp

FlippR-Driver/src/output/items/detail/SevenDigitDisplay.h

@@ -7,7 +7,7 @@
 
 #include "output/items/SevenDigitDisplay.h"
 
-#include "output/items/impl/Display.h"
+#include "output/items/detail/Display.h"
 
 namespace flippR_driver
 {
@@ -15,7 +15,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 class SevenDigitDisplay : public Display<7>, public items::SevenDigitDisplay

FlippR-Driver/src/output/items/detail/Solenoid.cpp

@@ -13,7 +13,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 Solenoid::Solenoid(std::shared_ptr<DriverBoardPinController> pin_controller, uint8_t address, std::string name, std::chrono::milliseconds deactivation_time)

FlippR-Driver/src/output/items/detail/Solenoid.h

@@ -20,7 +20,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 class Solenoid : public DriverBoardItem, public items::Solenoid

FlippR-Driver/src/output/items/detail/Sound.cpp

@@ -15,7 +15,7 @@ namespace output
 {
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 Sound::Sound(std::shared_ptr<SoundBoardPinController> pin_controller, uint8_t address, std::string name, std::chrono::milliseconds deactivation_time, u_int id)

FlippR-Driver/src/output/items/detail/Sound.h

@@ -25,7 +25,7 @@ class SoundBoardPinController;
 
 namespace items
 {
-namespace impl
+namespace detail
 {
 
 class Sound : public Item, public items::Sound